Recent
Categories
View Replies (5)

London Template - new font and body font size does not work

  1. Bug
0
Votes
Undo
  1. Oliver
    Oliver
  2. Sherlock Holmes The Voice
  3. Commercial Templates
  4. Saturday, 25 March 2017
  5.  Subscribe via email
Hello Ciaran,
I am just working on a redesign for a client and I am using London template.
I added a new Googlefont (as decribed in the tutorial) and added the line 


$googleFonts['Noto+Sans'] = 'Noto Sans';

to the templates/j51_london/elemts/googlefonts.php.

It works in the backend so I can choose the new font.

I also changed in the template options in General > Typography Styling the body font from "Medium" to "Large".

But in frontend nothing changed.

When i check the elements in the maincontent I get the following css code:


body {

    color: #525252;

    font-family: Nunito Sans font-size: 17pxpx;

}

body {

    line-height: 1.8rem;

    font-weight: 400;

}

body {

    font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;

    font-size: 14px;

    line-height: 20px;

    color: #333333;

}


as you see the syntax in the inline font declaration is wrong - no linebreak and double "px" so the template goes to the fallback with "Helvetica Neue" and 14px.

The error is in the inc/style.php.

I added at line 7 a ";" at the end. This is for ending the font-family declaration.
And in line 8 I deleted the "px" at the end because we get the font-size value from the templateDetails.xml WITH px.....

Hope you can use this.

Regards
Oliver
Responses (5)
ciaran
ciaran
Love Fool Sherlock Holmes The Voice
Notable Answerer Notable Answerer
Accepted Answer Pending Moderation
0
Votes
Undo
Good morning Oliver

May I suggest sending temporary administration access to your Joomla installation to info@joomla51.com and we will examine this issue further. For our reference please paste a link to this post in your email.

Ciarán
  1. more than a month ago
  2. Commercial Templates
  3. # 1
Oliver
Oliver
Sherlock Holmes The Voice
Accepted Answer Pending Moderation
0
Votes
Undo
Hi Ciaran,

I will send you the login data, but on my page it is now working because I have changed style.php.
So you will not find an error there anymore ;)

May I suggest to check the original London inc/style.php?

I just opened the original script file, downloaded March 21st.

It looks like this:


.logo-text h1 a {

	color: '.$this->params->get('logo_font_color').';

	font-family:'.str_replace("+"," ",$logo_fontstyle).'

	font-size: '.$this->params->get('logo_font_size').'px;

}


As you can see there is no end ";" in the line with the font-family declaration and there is a "px" at the end of the font-size declaration.
Its line 59 and 60 in the original script!
This two lines will lead to this syntax appearing in the frontend source code:


body {

    color: #525252;

    font-family: Nunito Sans font-size: 17pxpx;

}


Still wanna have the login data? ;)
Regards
Oliver
  1. more than a month ago
  2. Commercial Templates
  3. # 2
ciaran
ciaran
Love Fool Sherlock Holmes The Voice
Notable Answerer Notable Answerer
Accepted Answer Pending Moderation
0
Votes
Undo
Thank you Oliver for bringing this to our attention. The template download has updating amending this issue.

In the last number of weeks we have been doing a fairly extensive update of our framework and our London template was the first to use this. Hopefully this is the last of the issues resulting from all the changes :)

Thank you again for bringing this and previous issues to our attention!

Ciarán
  1. more than a month ago
  2. Commercial Templates
  3. # 3
Oliver
Oliver
Sherlock Holmes The Voice
Accepted Answer Pending Moderation
0
Votes
Undo
Hello Ciarán,

I am just working on the Magnolia template and I have nearly the same issue there.

In the template options >> Typography Styling I changed the body font size from medium to large. In the frontend I get this:



body {

    color: #525252;

    font-family: Open Sans;

    font-size: 17pxpx;

}


As you see there are double pxpx at the font-size declaration.

I downloaded Magnolia today and used version from 10. October. So maybe you have a look at the template and change this too?

Either changing the inc/style.php at line 9 and deleting the "px" at the end or deleting the "px" in the option values in the templateDetails.xml on line 176 to 178.
I changed the style.php because I am lazy :) :)

Just for your interest ;)

Oliver
  1. more than a month ago
  2. Commercial Templates
  3. # 4
ciaran
ciaran
Love Fool Sherlock Holmes The Voice
Notable Answerer Notable Answerer
Accepted Answer Pending Moderation
0
Votes
Undo
Thank you Oliver

I am not sure how we keep missing this one :/

We have updated the template download, resolving this issue.

Ciarán
  1. more than a month ago
  2. Commercial Templates
  3. # 5
  • Page :
  • 1


There are no replies made for this post yet.
Be one of the first to reply to this post!